Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DatabaseMetaData.getDatabaseCompatabilityLevel #1345

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Added DatabaseMetaData.getDatabaseCompatabilityLevel #1345

merged 2 commits into from
Jun 15, 2020

Conversation

dhait
Copy link
Contributor

@dhait dhait commented May 28, 2020

Implemented a new function to SQLServerDatabaseMetaData to check database compatibility level.

@dhait dhait mentioned this pull request May 28, 2020
Closed
@dhait
Copy link
Contributor Author

dhait commented May 30, 2020

The failure on Windows build was TVPAllTypesTest.testTVPStoredProcedureResultSet(TVPAllTypesTest.java:134)
This is unrelated to my code changes.
Is it possible to investigate and rerun the test build?

@dhait dhait requested a review from lilgreenbird May 31, 2020 12:50
@ulvii ulvii added this to the 8.4.0 milestone Jun 9, 2020
@peterbae peterbae added the Public API Changes in Public API label Jun 11, 2020
@ulvii
Copy link
Contributor

ulvii commented Jun 15, 2020

Thanks for the contribution @dhait .

@ulvii ulvii merged commit 559577f into microsoft:dev Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbae peterbae peterbae approved these changes

@ulvii ulvii ulvii approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@rene-ye rene-ye rene-ye approved these changes

Assignees
No one assigned
Labels
Public API Changes in Public API
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dhait @ulvii @rene-ye @lilgreenbird @peterbae